Install yamllint directly to use latest version
#3935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
changed the title
yamllint directly to use latest version
easyt
reviewed
Sep 4, 2024
shiftkey
force-pushed
the
shiftkey-patch-2
branch
from
25af9da to
96c77af
Compare
shiftkey
commented
Sep 4, 2024
shiftkey
commented
Sep 4, 2024
| - name: Install Node modules | ||
| run: npm ci | ||
| - name: JSON Lint | ||
| run: npm run lint |
There was a problem hiding this comment.
🤔 this command is also hard-coded to run with descriptions
rest-api-description/package.json
Line 10 in 272a391
shiftkey
force-pushed
the
shiftkey-patch-2
branch
from
1262056 to
22da1c8
Compare
bearcherian
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also attempts to use the latest version of
yamllintwithout depending on an action to see where the current bottlenecks are.This also allows us to set both of these linter checks as required to avoid accidentally merging PRs that aren't valid.